Usenet 1994 October/usenetsourcesnewsgroupsinfomagicoctober1994disk2.iso/x/volume13/xmail/part06/CHANGES

Text File | 1991-06-15 | 22KB | 451 lines

                                                                 April, 1991

   The following changes have been effected for Patchlevel 3 of xmail.

  Many, many bugs have been fixed, and the overall size of the resident image
has been cut almost in half.  I also believe I have correct all memory leaks.

  Support is now provided for displaying the content of an X-Face: header, as
a compile time option.  If you currently have the compface library routines
provided by James Ashton, see the Imakefile and change the flags accordingly.
The compface library routines are available from the Rich Burridge Archive
Server, at <[e-mail]>.  Send the one word subject "Help"
if you have never used this archive-server before.  These routines are
also included as part of Rich Burridge's faces program, also available from
that same address.


Imakefile:    Eliminated R3 support and changed number and type of defines

HelpText.c:    Modified some text and added information messages for commands

Mailwatch.c:    Added support to display either user or mail host name in icon
        Changing the icon tag also changes the application title for
        window managers, for those cases when more than one copy of the
        program being run.  Removed support for X11R[23].

actions.c:    Removed support for X11R3.  Changed ``Send'' completion popup
        to use callbacks instead of action routines.  Eliminated need
        for DoAutograph() and DoDone() action routines.  Changed routine
        SelectionNumber() to use greater-than mark as reference instead
        of current insertion pointer, because forward/backward-page
        et.al. messed with current insertion pointer location.  Added
        support for WM_DELETE_WINDOW protocol requests to DoQuit().
        Added information messages for each command button.  Message
        content is triggered by enter/leave notify events, ala xrn.
        Cleaned up error messages to use XtError().  Consolidated
        various popup positioning routines into SetXY().  Changed
        SetCursor() from XtActionProc to void and moved it to utils.c

callMail.c:    Added (UNTESTED) support for non-BSD style communications.
        The additional code was taken from the X11R4 sources for xterm.
        Non-BSD routines are untested by the author, as I do not have
        access to a System-V environment.  Eliminated hanging of the
        parent (for approximately 15 seconds) on close of the slave
        connection due to child terminated for lack of mail before
        the parent could issue it's close statement.  Fixed the bug for
        not displaying tabs in messages.

callbacks.c:    Call the alias() extraction routine recursively, to accommodate
        nested user aliases.  Also pass the recipient list to sendmail
        on the command line, in lieu of the ``-t'' option, to eliminate
        a bug which sometimes caused sendmail to think the author of
        the message was actually one of the recipients.  Add the USENIX
        X-Face: header to outgoing messages, if a ``.face'' file exists
        in the user's home directory.  Corrected a bug because System-V
        sprintf() does not return a pointer to the buffer.  Corrected
        redundant usage of XtNameToWidget() calls.  Changed occurrences
        for all of index() to strchr() to eliminate bug under SunOS_4+.
        Changed search for author in incoming messages to use ``From:'',
        ``Return-Path:'', and finally ``From '' header fields.  Changed
        control loop for confirms and ``Send'' completion popups so
        that they will be displayed even if the parent is obscured.
        Changed ``outfolder'' to work as documented in Mail man page.
        Fixed Done routine to not create header files when aborting a
        message composition.

defs.h:        Eliminated some global variables and support for X11R3.  Added
        declaration for editorCommand resource, and support for those
        environments which do not include a wait3() system call.

directory.c:    Changed define declaration to USE_DIRENT, because structure
        dependency is not SUN_OS dependent.

environs.c:    Changed occurrences of index() to strchr().  Added support for
        braced and quoted environment variables.  Added recursive
        parsing of the .mailrc file for ``source''d files.  Added
        recursive parsing of the aliases for addresses, carbon, and
        blind copies.  Merged the extraction of aliases and set options
        from the mailrc file into one routine.  This routine now also
        supports continuation lines, and returns the LAST occurance of
        the targeted set option.  This last point fixes a bug where the
        user declared a prompt string more than once in the mailrc
        file.  Mail would use the second one, while previous version of
        xmail were looking for the first and hanging indefinitely.

handler.c:    Added info_handler() to write command button window explanation
        messages in the status window on enter/leave-notify events.
        Fixed bug in placing marker for current message.  Changed all
        occurrences of index() to strchr().  Fixed bug in index_handler
        when the current message index went to zero due to a loss of
        sync with the incoming text from Mail.  This would occur if the
        user pressed the read next/previous message keys too rapidly.

mail.c:        Added support for the editorCommand resource, ala xrn.  This
        resource allows the user to specify an ``sprintf''-able string
        which defines the editor to use when composing messages.  Users
        must supply two ``%s'' entry points, one for the name of the
        X display connection and one for the name of the edited file.
        Fallback to the previous VISUAL methodology, if editorCommand
        specification does not meet requirements.  Corrected a bug
        which prevented the ``Send'' popup from appearing if the parent
        shell was partially or totally obscured.  Made the ``Send''
        popup reusable, instead of destroying and recreating it each
        time.  Accommodated people who insist on setting a wide border.

national.bm:    Resized the logo to a larger format, to better fit the titleBar.

parser.c:    Corrected a bug for those cases when the mail process would
        disappear unexpectedly.  Loss of connection no longer causes
        a runaway condition.  Fixed a bug in the START process which
        chewed up CPU seconds when started iconic.  Restored function-
        ality for the no-autoprint option, which also fixed a bug of
        occasionally seeing titlebar or status info in the text window
        when issuing read previous/next commands in rapid fashion.

revtable.h:    Used in un-compressing X-Face headers.

utils.c:    Added support for proportionally spaced fonts, using routine
        figureWidth().  Added support for X-Face headers on in-coming
        messages.  If found, the X-Face will be displayed in the upper
        right-hand corner of the text window.  Modified Bell() routine
        to not replace message text in status window if previous text
        was for an error.

windows.c:    Moved a majority of the action translation tables to the XMail
        class resource file, to allow the user more flexibility.

xmail.c:    Changed the startup procedure to not start in the system folder
        if starting iconic, to prevent ``newmail'' flag from being reset
        before the user has opened the icon for the first time.  Added
        separate font declarations for help, text, and button fonts.
        Added resources and command line options for disabling the new
        info feature and for specifying the editorCommand format string.
        Fixed calculations for overall shell size if user has specified
        a proportional font or wide borders, to keep xmail shell within
        root window boundaries.

The following persons have sent in suggestions, complaints, and/or patches
which have contributed to the development of this patchlevel.  In most cases,
I was able to respond directly to the submitter using the address indicated.
In some cases, mail would bounce and I could not reach them with a thank-you.
In any case, I wish to express my deepest gratitude to all for their interest
and assistance.  If I have inadvertently managed to leave someone's name off
of this list, please forgive me (and thanks again).

Alan M. Baum    <[e-mail]>
    requested the ability to recursively parse an alias during ``Send''

Dana A. Chee    <[e-mail]>
    one of many to request resources be moved to the application defaults

Damian Chu    <[e-mail]>
    forced me (%^) to add WM_DELETE_WINDOW protocol support  (thanks)

Ned Danieley    <[e-mail]>
Frank Peters    <[e-mail]>                and
Thomas Oeser    <[e-mail]>
    identified problems (non-RFC822 compliance) with address parsing

Norm Jacobs    <[e-mail]>
    provided suggested code patches for System-V socket connections

Casey Leedom    <[e-mail]>
    identified bugs in the translation tables and suggested the addition
    of the editorCommand resource specification

Steve Losen    <[e-mail]>
    identified bugs in the translation and regular expressions tables

Andrew McRae    <[e-mail]>            and
Peter Morreale    <[e-mail]>
    identified the existence of memory leaks in patchlevel 2

Frans Meulenbroeks <[e-mail]>
    suggested the need to use the ``source'' command in .mailrc

Marc H. Scholl    <[e-mail]>
    suggested changes in the ``outfolder'' variable interpretation

Brian V. Smith    <[e-mail]>
    noted that the ``Send'' popup would not appear if the xmail parent
    window (or icon) was obscured


---------------------- end of changes for patchlevel 3 -----------------------

                                                                August, 1990

   The following changes have been effected for Patchlevel 2 of xmail.


Imakefile:    Reordered R3 and R4 dependencies to allow for R4 make depend.

HelpText.c:    Corrected some text and added help for text window key actions.

Mailwatch.c:    Added option to start icon in reverse video.  Also added
        option to display the username in the icon window, for those
        times when xmail processes for more than one user are desired.

actions.c:    Changed Newmail action to NOT automatically remove the
        current folder list when changing to the system mail folder.
        'Drop Folders' is now a separate action selectable within the
        Newmail command menu.  Fixed SetFolders routine to not prepend
        the home directory to folder names beginning with either a
        dot (.) or foreword slash (/).  Also added a COMMIT option
        to change of folder (when current folder has deleted mail)
        or cancel of composed message.  Commit option is tailorable
        by -e (expert) flag, 'Preserve' menu selection, and/or resource
        specification.  Re-edit of the current message composition is
        now supported within the 'Send' popup 'Deliver' sub-menu.
        Deletions in the 'Send' popup text fields will no longer force
        the cursor position to the end of the line.  Additional error
        messages from the mail program are also trapped.  To better
        support variations in 'Berkeley' mail, 'set no' commands are
        no changed to 'unset' commands.  Both forms are also parsed.
        To allow pasting of selected text within the various windows,
        message indexing is now indicated by a preceding greater-
        than symbol (>) instead of highlighting using the selection
        mechanism.

callbacks.c:    Mechanisms for delivering mail messages are now forked to a
        child process if possible, instead of the previous synchronous
        system calls.  Better support for file and folder recipients
        to messages are also included.  Changes in folder or quitting
        with a modified folder are now confirmed, unless the expert
        flag has been specified.  Callbacks for re-editing message
        composition and for dropping the current folders list are also
        added.

confirm.c:    This is a new routine which supplys the confirmation method.

defs.h:        Changes to accommodate 'make depend' under X11R4 .vs. X11R3.
        Added command line option flag: expert.

directory.c:    Modified list display to be more box like, to help prevent
        the menu from running off the bottom of the screen.

environs.c:    Improved alias parsing routines to separate real people from
        file and folder names as recipients of mail messages.  Also
        expanded environment variables in GetMailEnv calls.

globals.h:    Added definitions for new routines and flags.

handler.c:    Removed widget privates dependencies in SystemFolder routine
        by correctly calling XtGetValues for the label of the widget.

icon.mail:    Modified bitmaps for both icons to allow for placing the
        username under the mailbox, when requested.

mail.c:        Added editMail routine to support re-edits of message text.

parser.c:    Added ability to export the match function to other routines
        for better handling of errors from mail.  Changed 'set no'
        calls to 'unset's, for support of SONY NEWS OS mail program.
        Changed message index highlighting to use the greater-than
        symbol (>) instead.  Revert to default mail prompt of received
        during startup, for case where user's .mailrc file fails to
        parse before the intended prompt can be set.

utils.c:    Changed message index selection highlighting to use symbol.

windows.c:    Added new command menu options.  Provided for cut and paste
        operations in File and text windows.  Added second help
        window to text area for mapping of keyboard keys to command
        actions.  Added keyboard cursor motion commands to the Index
        and Text windows.  Added routine to parse the icon geometry.

xmail.c:    Added support for new options: -e (expert), -iconic, and
        -rv (reverse video on the icon).  Also default to no position
        (0,0) for icon if not explicitly specified.

xmail.man:    Many changes to document patchlevel 2 enhancements and fixes.

xmailregex.h:    Added support for use outside of the parser routines.  Also
        added additional error messages for users with problems in
        their environment or .mailrc file.

XMail.ad:    Changed the color specifications in the applications defaults
        from names to hex values, to provide support when the server
        fails to parse color names (a rare but annoying occurrence).
        Added definitions for the new command menu buttons.


Again, I'd like to thank the contributors of suggestions and actual patches.
I'd also like to thank those persons who sent in complaints and suggestions.
If I somehow managed to forget some of those persons, I hope they can
forgive me.

*) Jeff Dauber was first to request the ability to re-edit new messages.

*) Mark Scholl was responsible for requesting the addition of a Confirmation
   option.

*) More illegal pointer combination fixes, the ParseIconGeometry() routine,
   and the expansion of environment variables within the GetMailEnv() routine
   were supplied by Christos Zoulas.

*) Tom Dunigan and Peter Marshall both pointed out the error of my ways in
   handling RFC822 addresses, and supplied much needed help in making the
   corrections.

*) Peter Marshal also initiated changes to allow a greater variety of editor
   choices, including better support for the emacs invocation.  He was also
   one of the first to complain about the delays during delivery of messages,
   which drove the efforts to fork off those tasks.

*) David Elliott suggested the no-default icon position, the missing paste
   ability in the File window, and the need to support 'unset' versus 'set no'
   construct in mail.

*) Suggestions from Casey Leedom precipitated the revision of the Makefile
   depends to provide better support for make depend under Sun and X11R4.

*) Questions from John Meissen prompted modifications to the way the file
   handlers are modified when calling mail and forking edit children.  He also
   pointed out the probability of a MAIL environment variable pointing to
   the intended mail spool and made suggestions for changing the code.

---------------------- end of changes for patchlevel 2 -----------------------

                                                                   May, 1990

   The following changes have been effected for Patchlevel 1 of xmail.


Imakefile:    Made improvements in dependencies and SunOS defines.
        Removed requirement for linkage to system math library.

HelpText.c:    Text revised and reformatted to better fit the help window

Mailwatch.c:    Corrected illegal pointer combinations and added resources
        to allow the user to specify the number of times to ring the
        bell when new mail has arrived.  Fixed new mail bell to ring
        only if flag is not already up.

Mailwatch.h:    Eliminated warning for duplicate XtNfile definition

actions.c:    Corrected illegal pointer combinations, added support for
        improved index handler and Blind carbon copies.  Also added
        support for .mailrc "printmail" definition, and improved error
        messages when attempting to select non-existent or undefined
        mail folders.  Used integer math instead of sqrt() function to
        calculate box dimensions for aliases list.

callMail.c:    Corrected attempts to write to read-only strings, and fixed
        case where fork child dies for improper command arguments or
        illegal or unfound image execution which tried to write error
        messages to the xmail pipe instead of the terminal screen.
        A dying child process now also terminates the xmail process.

callbacks.c:    Added support for external sendmail function, improved index
        handler, and mail variable 'alwaysignore' which is now used
        to determine header levels for reply, forward, and printed
        messages.  If recipient selection fails to find a value for
        the <Return_Path:> to a message, the <From:> designate is now
        used, to eliminate failures to provide a <To:> addressee.
        Also fixed bug in replyalls which failed to pick up names from
        the original To: field when preparing addresses for the reply.

defs.h:        Changed TITLE definition to accommodate use of PATCHLEVEL.

environs.c:    Alias support has been extended to include the word 'group'
        when manually extracting mail aliases from the user's .mailrc
        file.  Support has also been included for continuation lines.
        Mechanisms to expand the MAILRC environment variable definition
        have been eliminated, so that xmail behaves more like mail.
        Corrected a bug in getMailEnv to return 'True' for variables
        which have no additional value, such as 'hold' or 'autoprint'.
        Changed strchr() calls to index().

handler.c:    Function icon_handler() has been added to switch xmail to a
        dummy mail folder whenever the application is iconified, and
        to switch back to the previous folder on de-iconification.
        Improved index_handler() to eliminate repaints of the index
        window for every deletion or undeletion.  Also added code to
        display as many new message headers as possible, to eliminate
        unnecessary scrolling of the index window.

mail.c:        Changed the fputs() to a write() to help eliminate i/o hanging,
        added Blind Carbon Copy support to the sendMail function, and
        added XMail class resources to the xterm message entry window.
        Changed strrchr() call declarations to rindex().

parser.c:    Eliminated multiple redraws of the index window during message
        deletions, and corrected index message markers for 'N'ew,
        'D'eleted, and undeleted mail messages.  Corrected a bug in the
        delete processing to not reread entire message and corrected a
        bug to erase index and text window datas if no current folder.

utils.c:    Added use of PATCHLEVEL in determining TITLE version revision
        and changed calls for strchr() to index().

windows.c:    Changed name of "hold" button to "preserve", to better match
        error message text when used incorrectly, eliminated making
        the preserve button insensitive, to allow use of "set" menu
        in any folder, added a "set" menu to the "preserve" command
        button, to toggle mail variables, "alwaysignore", "autoprint",
        and "hold", and corrected character processing in the file
        window, to allow deletion and insertion within the line,
        instead of always at the end.  Added use of PATCHLEVEL in
        determining TITLE version revision

xmail.c:    added support for the -iconic command line option, corrected
        resource handling for iconGeometry, and improved default font
        handling for minimum dimensions of the xmail application window.
        Also fixed processing of geometry specifications for the top
        level window.  Update the 'what' database string to reflect
        current version.



I would like to thank the many contributors of suggestions and actual patches.
I would also like to thank those persons who sent in complaints, as they were
often the predictors of the many other corrections and enhancements to xmail.

*) Message size tests in parser.c were extended to include support for DEC
   mail return on size requests, to prevent core dumps under Ultrix UWS 2.2
   thanks to patches from Dirk Grunwald <[e-mail]>

*) Corrections to Imakefile to eliminate the need to set SunOS dependency
   flags manually were driven by suggestions from Casey Leedom
   <[e-mail]> and David Elliott <[e-mail]>.

*) The regular expressions definitions in xmailregex.h were corrected as a
   result of suggestions from Casey Leedom.

*) Suggestions from Casey Leedom, Mark Williams <[e-mail]>,
   and Mark Scholl <[e-mail]> helped identify a problem in the
   communications links with mail.  writeMail() now uses a write instead
   of fputs, and the connection parameters are set for APPEND instead of
   non-blocking i/o, to eliminate run-away cpu cycles.

*) Many, many illegal pointer combination errors were identified and corrected
   by Christos Zoulas <[e-mail]>

*) Thanks go to Robert Viduya <[e-mail]> for suggestions
   and assistance in adding an icon handler to switch to a dummy mail folder
   during iconification, to prevent collisions in mail if run from another
   process while xmail is running.

*) Support for an alternate sendmail function was provided after receiving
   suggestions from Jim Blythe <[e-mail]>

*) Blind carbon copy support and correction of several bugs were suggested
   by Jeff Dauber <[e-mail]>

*) Support for mail variables autoprint and hold were corrected thanks to
   requests from Dwayne Lee <[e-mail]>